tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix 
RocksDBStateBackend's mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#issuecomment-486123512
 
 
   Hmm, isn't the problem that we never call `SnapshotDirectory#mkdirs` on the 
returned temporary `SnapshotDirectory`? It just happens to be the case that we 
created the local checkpoint directory when calling 
`AbstractFsCheckpointStorage#createCheckpointDirectory` before. This case seems 
to be not properly tested.
   
   So I see two problems right now:
   
   1. We are not creating the `SnapshotDirectory`.
   2. We allow a temporary `SnapshotDirectory` to be located anywhere. Maybe it 
would make sense to only allow local temporary directories.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to