tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix 
RocksDBStateBackend's mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#issuecomment-486331017
 
 
   Implicitly relying on the fact that someone else has created the directory 
is dangerous and super brittle imo. Moreover, the code in this location does 
not enforce by any mean that we use the local file system. Afaik RocksDB needs 
a local directory for checkpointing but if this is the case, then we should 
explicitly enforce it (e.g. allowing only local temporary 
`SnapshotDirectories`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to