azagrebin commented on a change in pull request #8181: [FLINK-12199][network]
Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#discussion_r278558571
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -666,7 +674,7 @@ public static SingleInputGate create(
NetworkEnvironment networkEnvironment,
TaskEventPublisher taskEventPublisher,
TaskActions taskActions,
- TaskIOMetricGroup metrics) {
+ TaskIOMetricGroup parent) {
Review comment:
Here, we create the same `InputChannelMetrics` multiple times.
I would create `InputChannelMetrics` once in Task and pass it to the
`create` method along with
`numBytesInCounter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
