azagrebin commented on a change in pull request #8181: [FLINK-12199][network]
Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#discussion_r279323553
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -561,6 +567,7 @@ public void requestPartitions() throws IOException,
InterruptedException {
}
final Buffer buffer = result.get().buffer();
+ numBytesIn.inc(buffer.getSizeUnsafe());
Review comment:
This should be just yet another new total counter for all tasks (local +
remote channels). Old counters with local and remote separation should stay as
internal specific metrics of network environment. At the end of the day, total
= local + remote and used directly without summing of specific counters outside
of network environment in IOMetrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
