azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r278627976
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -89,6 +109,8 @@ public NetworkEnvironment(
registerNetworkMetrics(metricGroup, networkBufferPool);
+ this.ioManager = checkNotNull(ioManager);
Review comment:
`ioManager` looks like one more dependency for `ShuffleService` at the
moment. Maybe, we could somehow get rid of it in future because it might be mot
relevant for all shuffle services. I see it is used in other components. Maybe,
we could create a separate `ioManager` inside netty shuffle service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
