azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r279726101
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -220,6 +222,8 @@ public void setup() throws IOException {
jobManagerLeaderRetriever = new
SettableLeaderRetrievalService();
haServices.setResourceManagerLeaderRetriever(resourceManagerLeaderRetriever);
haServices.setJobMasterLeaderRetriever(jobId,
jobManagerLeaderRetriever);
+
+ networkEnvironment = new NetworkEnvironmentBuilder().build();
Review comment:
should we call `networkEnvironment.start();`? or at least keep it in
`testShouldShutDownTaskManagerServicesInPostStop`? Also in `TaskAsyncCallTest`
and `TaskTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
