zhijiangW commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r278804998
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -940,9 +943,7 @@ private void setState(Task task, ExecutionState state) {
consumableNotifier = new
NoOpResultPartitionConsumableNotifier();
partitionProducerStateChecker =
mock(PartitionProducerStateChecker.class);
- final ResultPartitionManager partitionManager =
mock(ResultPartitionManager.class);
- networkEnvironment = mock(NetworkEnvironment.class);
-
when(networkEnvironment.getResultPartitionManager()).thenReturn(partitionManager);
+ network = networkEnvironment;
Review comment:
That is fine.
I could remove `setNetworkEnvironment` in `TaskBuilder` and then make the
private variable `network` as final in `TaskBuilder`. The new constructor
`TaskBuilder(NetworkEnvironment)` is defined with the default
`newTaskBuilder()` for creating it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
