zhijiangW commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r278806215
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -89,6 +109,8 @@ public NetworkEnvironment(
registerNetworkMetrics(metricGroup, networkBufferPool);
+ this.ioManager = checkNotNull(ioManager);
Review comment:
Yes, it would be better to create all the required components inside
specific `ShuffleService` implementations.
I just quickly reviewed the current usages of `IOManager`. For streaming
jobs, the `BarrierBuffer` would be finally not using `IOManager` any more to
cache blocked buffers in memory directly. And the `RocksDBStateBackend` only
uses the `IOManager` to get path which might be done in other options I think.
So the key blocker for `IOManager` usage is from batch jobs, which relies on it
heavily atm.
Maybe we could create private `IOManager` inside `ShuffleService` as you
suggested in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
