StefanRRichter commented on a change in pull request #7571: [FLINK-10724]
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r278920522
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
##########
@@ -210,7 +212,7 @@ private void restart(long globalModVersionOfFailover) {
// we restart the checkpoint scheduler
for
// i) enable new checkpoint could be
triggered without waiting for last checkpoint expired.
// ii) ensure the EXACTLY_ONCE
semantics if needed.
-
executionGraph.getCheckpointCoordinator().abortPendingCheckpoints(new
Exception("FailoverRegion is restarting."));
+
executionGraph.getCheckpointCoordinator().abortPendingCheckpoints(new
CheckpointException(CheckpointFailureReason.JOB_FAILURE));
Review comment:
Also strictly speaking, this is not exactly a job failure, it is a partial
failure of the job in one region. Thinking about if this might justify it's own
failure cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
