StefanRRichter commented on a change in pull request #7571: [FLINK-10724] 
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r278912637
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -700,7 +705,7 @@ else if (!props.forceCheckpoint()) {
                                        LOG.warn("Cannot dispose failed 
checkpoint storage location {}", checkpointStorageLocation, t2);
                                }
 
-                               return new 
CheckpointTriggerResult(CheckpointDeclineReason.EXCEPTION);
+                               throw new 
CheckpointException(CheckpointFailureReason.EXCEPTION);
 
 Review comment:
   Same here, we could add the cause to the constructor for debugging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to