Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38865859
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/AbstractStormSpoutWrapper.java
---
@@ -97,9 +102,20 @@ public AbstractStormSpoutWrapper(final IRichSpout spout,
}
@Override
+ public void open(Configuration parameters) throws Exception {
+ config = new HashMap();
+
+ /* parameters is task configuration, we can get storm
configuration only from job configuration */
+ Map stormConf =
StormWrapperSetupHelper.getStormConfFromContext(super.getRuntimeContext());
+ if (stormConf != null) {
+ config.putAll(stormConf);
+ }
+ }
--- End diff --
I just had a closer look at the code. Because we do not use the given
`Configuration`, we should move the code into `run` method and remove the
overwrite of `open()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
