Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38867892
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/StormFileSpout.java
---
@@ -45,9 +49,16 @@ public StormFileSpout(final String path) {
public void open(final Map conf, final TopologyContext context, final
SpoutOutputCollector collector) {
super.open(conf, context, collector);
try {
+ /* If config is given, it should override constructor
path */
+ if (conf != null && conf.containsKey("textpath")) {
+ this.path = (String)conf.get("textpath");
+ }
+
this.reader = new BufferedReader(new
FileReader(this.path));
} catch (final FileNotFoundException e) {
throw new RuntimeException(e);
+ } catch (final NullPointerException e) {
--- End diff --
Why do you catch `NullPointerException`? Can be removed. NPE is a runtime
exception anyway and you just re-throw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
