azagrebin commented on a change in pull request #8320:
[FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r279770711
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -191,7 +191,7 @@
private final ResultPartition[] producedPartitions;
- private final SingleInputGate[] inputGates;
+ private final InputGate[] inputGates;
Review comment:
I would keep it as `SingleInputGate[]` to avoid that copying loop
`SingleInputGate[]` -> `InputGate[]` in Task constructor at the moment.
Later, we could move `inputGatesById` completely to `NetworkEnviroment`,
when we refactor:
- `TaskExecutor.updatePartitions` to use
`NetworkEnviroment.update(PartitionInfo)`
- try to move `triggerPartitionProducerStateCheck` to `SingleInputGate` and
pass `partitionProducerStateChecker` to `SingleInputGate` instead of having it
in `TaskActions`
`inputGatesById` looks like the last blocker to change `SingleInputGate[]`
-> `InputGate[]` in Task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
