[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833507#comment-16833507
]
Hequn Cheng commented on FLINK-12348:
-------------------------------------
Hi [~jark], thanks for the detailed description and discussions offline. It's
good to make it also configurable from a yaml file. For example, user defined
flink platforms can make use of it directly rather than do some wrapping.
In order to support it, we may need to solve another problem: if we add a
`conf` member in TableConfig, the configurations in `conf` may conflict with
the member variable in TableConfig. Take timezone as an example, there is also
a member variable in TableConfig. To make it consistent, we may remove the
timezone variable and only store it in the `conf`. Configurations except for
PlannerConfig can be moved into the `conf` similar to timezone.
What's your opinions on it? [~twalthr] [~dawidwys]
Best, Hequn
> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -----------------------------------------------------------------------------
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
> Reporter: Jing Zhang
> Assignee: Jing Zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
