[ 
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833789#comment-16833789
 ] 

Jark Wu commented on FLINK-12348:
---------------------------------

+1 provide methods for frequently used properties.

Regarding to the naming of properties, I think you raised a good point, this is 
what I want to discuss next. I think it's nice to follow descriptor properties, 
actually we also use this pattern in Blink properties. 

Regarding to the hierarchy of properties, we split the options into following 
in Blink:
* {{sql.exec.xxx}} for runtime
* {{sql.optimizer.xxx}} for optimizer
* {{sql.resource.xxx}} for resource, e.g. memory, parallelism, cpu
* {{sql.codegen.xxx}} for codegen

I'm not sure there should be a planner hierarchy. IMO, planner is a little 
broad for users, it seems that it includes optimizer, codegen, resource, etc..

Maybe we should draft a google doc to list all the properties will be added in 
the near future (mostly from Blink planner, shall we go through every property 
name from Blink?). So that we can have an overview of properties to   have a 
better hierarchy.

> Use TableConfig in api module to replace TableConfig in blink-planner module.
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-12348
>                 URL: https://issues.apache.org/jira/browse/FLINK-12348
>             Project: Flink
>          Issue Type: Task
>          Components: Table SQL / API
>            Reporter: Jing Zhang
>            Assignee: Jing Zhang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in 
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig 
> in blink-planner-module should not exist anymore. The issue aims to remove 
> the TableConfig in blink-planner-module, use TableConfig in API module 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to