[ 
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833861#comment-16833861
 ] 

Timo Walther commented on FLINK-12348:
--------------------------------------

Yes, a little design doc with a table of "property name", "description" sounds 
good. We can then reuse this design doc also for the implementation.

My only concern right now is that we should separate planner-related and 
API-related configuration. We recently introduced a {{PlannerConfig}} and I 
think most of the string-string map can be produced by this class. 
{{TableConfig}} should be used for more session-related properties or 
properties that almost every user needs to touch. We mentioned that in FLIP-32, 
{{TableConfig}} would abstract Flink's {{ExecutionConfig}} and would allow to 
set state backends, watermark intervals etc.

> Make TableConfig configurable from string-string map
> ----------------------------------------------------
>
>                 Key: FLINK-12348
>                 URL: https://issues.apache.org/jira/browse/FLINK-12348
>             Project: Flink
>          Issue Type: Task
>          Components: Table SQL / API
>            Reporter: Jing Zhang
>            Assignee: Jing Zhang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in 
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig 
> in blink-planner-module should not exist anymore. The issue aims to remove 
> the TableConfig in blink-planner-module, use TableConfig in API module 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to