wuchong commented on a change in pull request #8288: [FLINK-12345] 
[table-planner-blink] Add support for generating optimized logical plan for 
stream window aggregate
URL: https://github.com/apache/flink/pull/8288#discussion_r281446085
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/TableConfig.scala
 ##########
 @@ -53,6 +53,30 @@ class TableConfig {
     */
   private var maxGeneratedCodeLength: Int = 64000 // just an estimate
 
+  private val DEFAULT_FIRE_INTERVAL = Long.MinValue
+
+  /**
+    * The early firing interval in milli second, early fire is the emit 
strategy
+    * before watermark advanced to end of window.
+    *
+    * < 0 means no early fire
+    * 0 means no delay (fire on every element).
+    * > 0 means the fire interval
+    */
+  private var earlyFireInterval = DEFAULT_FIRE_INTERVAL
 
 Review comment:
   I think we can support it if we expose early&late interval through options 
in `TableConfig`.
   
   I think it's nice to have it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to