tillrohrmann commented on a change in pull request #8306: [FLINK-12342] Add 
fast-heartbeat-delay yarn config for  jobs with large number of containers
URL: https://github.com/apache/flink/pull/8306#discussion_r281525607
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -514,8 +514,7 @@ private void requestYarnContainer() {
                
resourceManagerClient.addContainerRequest(getContainerRequest());
 
                // make sure we transmit the request fast and receive fast news 
of granted allocations
-               
resourceManagerClient.setHeartbeatInterval(FAST_YARN_HEARTBEAT_INTERVAL_MS);
-
+               
resourceManagerClient.setHeartbeatInterval(containerRequestHeartbeatIntervalMillis);
 
 Review comment:
   It is not optimal but it should also not hurt too much. Moreover, at the 
moment this method is the common place which is called for every container 
request. Changing it should be out of scope for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to