tillrohrmann commented on issue #8242: [FLINK-6227][network] Introduce the 
DataConsumptionException for downstream task failure
URL: https://github.com/apache/flink/pull/8242#issuecomment-490484996
 
 
   > Catch parent IOException instead of PartitionNotFoundException in 
LocalInputChannel or PartitionRequestServerHandler during requesting partition. 
IOException could only happen in blocking result partition during opening disk 
file which might indicate the file corrupted/deleted. So the above cases of b, 
c are unified in this process. But there might exist concerns here:
   
   I'm not 100% sure whether we should always transform an `IOException` into a 
`PartitionNotFoundException` or whether we should on the producer side check 
whether the file still exists and if not throw an `PartitionNotFoundException` 
from there.
   
   A part from that, your proposed changes sound good to me. Please also open a 
JIRA issue for the missing parts (throwing a `PartitionNotFoundException` if 
the consumer cannot establish a connection to the remote TM).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to