StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r282401219
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
##########
@@ -296,7 +296,8 @@ public static ExecutionGraph buildGraph(
checkpointIdCounter,
completedCheckpoints,
rootBackend,
- checkpointStatsTracker);
+ checkpointStatsTracker,
+
chkConfig.getTolerableCheckpointFailureNumber());
Review comment:
Nit: this method is already taking all other fields from `chkConfig`. It
seems like this has super-high cohesion so maybe you could change it to pass in
the `chkConfig` instead of all fields on by one. Or at least position this
further up with the other calls on `chkConfig`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
