StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r283707598
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -539,22 +536,26 @@ public void enableCheckpointing(
checkpointStatsTracker = checkNotNull(statsTracker,
"CheckpointStatsTracker");
+ CheckpointFailureManager failureManager = new
CheckpointFailureManager(chkConfig.getTolerableCheckpointFailureNumber(), () ->
+ failGlobal(new FlinkRuntimeException("Exceeded
checkpoint tolerable failure threshold.")));
+
// create the coordinator that triggers and commits checkpoints
and holds the state
checkpointCoordinator = new CheckpointCoordinator(
jobInformation.getJobId(),
- interval,
- checkpointTimeout,
- minPauseBetweenCheckpoints,
- maxConcurrentCheckpoints,
- retentionPolicy,
+ chkConfig.getCheckpointInterval(),
Review comment:
Why not also pass the `chkConfig` as a whole to the `CheckpointCoordinator`?
The name of the config already suggests this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
