twalthr commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r283657017
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -280,6 +316,55 @@
*/
void sqlUpdate(String stmt, QueryConfig config);
+ /**
+ * Gets the current default catalog name of the current session.
+ *
+ * @return the current default catalog that is used for path resolution
+ * @see TableEnvironment#setCurrentCatalog(String)
+ */
+ String getCurrentCatalogName();
Review comment:
I'm also in favor of being consistent. If we have a `setCurrentCatalog`, we
should have a `getCurrentCatalog`. On the other hand, I also find it confusing
that "catalog" sometimes describes a catalog instance and sometimes a catalog
name. However, the SQL standard does the same with `USE DATABASE`. How about we
also introduce `useCatalog` and `useDatabase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
