twalthr commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r283706195
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/exceptions/DatabaseNotExistException.java
##########
@@ -25,10 +25,19 @@
public class DatabaseNotExistException extends Exception {
private static final String MSG = "Database %s does not exist in
Catalog %s.";
+ /**
+ * @param catalog Catalog name
Review comment:
unnecessary JavaDocs, instead one could rename the parameter names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services