azagrebin commented on issue #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#issuecomment-492236724 Thanks for the review @zhijiangW ! I have addressed smaller comments. 1. True, `PartitionInfo` looks similar to `IGDD`. The difference is atm that `PartitionInfo` represents update of only one (but any) gate channel. `IGDD` has a consistent view of all gate channels. Not sure, how well it is semantically to treat `IGDD` as one channel update. I will think about it. 2. In general, I do not see a problem with `instanceof` or what is the concern here? If we add more methods like `isUnknown()`, all `SDD`s will have to implement them. Of course, we can make them inherit from a base class but it will clutter their code. Also channel's unknownness is more a general concept of scheduling in the absence of producer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
