walterddr commented on a change in pull request #8324: [FLINK-11921][table]
Upgrade to calcite 1.19
URL: https://github.com/apache/flink/pull/8324#discussion_r284344927
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/AuxiliaryConverter.java
##########
@@ -53,25 +53,6 @@ public Impl(SqlFunction f) {
public RexNode convert(RexBuilder rexBuilder, RexNode groupCall,
RexNode e) {
return rexBuilder.makeCall(this.f, e);
- // FLINK QUICK FIX
- // we do not use this logic right now
-// switch (f.getKind()) {
-// case TUMBLE_START:
-// case HOP_START:
-// case SESSION_START:
-// case SESSION_END: // TODO: ?
-// return e;
-// case TUMBLE_END:
-// return rexBuilder.makeCall(
-// SqlStdOperatorTable.PLUS, e,
-// ((RexCall) groupCall).operands.get(1));
-// case HOP_END:
-// return rexBuilder.makeCall(
-// SqlStdOperatorTable.PLUS, e,
-// ((RexCall) groupCall).operands.get(2));
-// default:
Review comment:
good point. I should kept the comments. thanks for reminder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
