walterddr commented on a change in pull request #8324: [FLINK-11921][table] 
Upgrade to calcite 1.19
URL: https://github.com/apache/flink/pull/8324#discussion_r284344589
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
 ##########
 @@ -882,6 +968,12 @@ public static int ymdToJulian(int year, int month, int 
day) {
                int a = (14 - month) / 12;
                int y = year + 4800 - a;
                int m = month + 12 * a - 3;
+//             return day + (153 * m + 2) / 5
+//                     + 365 * y
+//                     + y / 4
+//                     - y / 100
+//                     + y / 400
 
 Review comment:
   these lines are explicitly comment out on purpose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to