zentol commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r284655543
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateConcurrentTest.java
##########
@@ -88,7 +90,9 @@ public void testConsumptionWithRemoteChannels() throws
Exception {
final ConnectionManager connManager =
createDummyConnectionManager();
final Source[] sources = new Source[numberOfChannels];
- final SingleInputGate gate =
createSingleInputGate(numberOfChannels);
Review comment:
the majority of these changes don't really seem necessary; we could just
modify `createSingleInputGate` to use the builder and keep it as a short-hand.
(btw., it is a bit odd that you aren't touching `InputChannelTestUtils` in this
commit)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
