zentol commented on a change in pull request #8416: [FLINK-12331] Introduce 
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r284672498
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannelTest.java
 ##########
 @@ -114,11 +114,12 @@ public void testConcurrentConsumeMultiplePartitions() 
throws Exception {
                                .setNumTargetKeyGroups(parallelism)
                                .setResultPartitionManager(partitionManager)
                                .setSendScheduleOrUpdateConsumersMessage(true)
+                               .setBufferPoolFactory(p ->
+                                       
networkBuffers.createBufferPool(producerBufferPoolSize, producerBufferPoolSize))
                                .build();
 
                        // Create a buffer pool for this partition
 
 Review comment:
   comment seems a bit out-dated, I'd probably just remove it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to