StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r284732143
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
##########
@@ -132,6 +132,17 @@ public long getAndIncrement() throws Exception {
}
}
+ @Override
+ public long get() {
+ ConnectionState connState = connStateListener.getLastState();
+
+ if (connState != null) {
Review comment:
Whenever you feel tempted to copy code from a method, maybe think about
extracting it into a common helper. This pattern get & check is just repeated
from `getAndIncrement`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
