StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r285038538
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -187,6 +187,7 @@ public void testRestoreBehaviourWithFaultyStateHandles()
throws Exception {
env.setParallelism(1);
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(Integer.MAX_VALUE,
0));
env.enableCheckpointing(10); // Flink doesn't allow lower than
10 ms
+
env.getCheckpointConfig().setTolerableCheckpointFailureNumber(Integer.MAX_VALUE);
Review comment:
Hm, this raises a bit of a red flag: if you need to adjust the test, does it
mean that the user facing default behaviour is changed by the PR? What I mean,
if we need to configure this to pass the tests do user have to change their job
as well to get the old behaviour? This looks like either i) a failer that was
tolerated before now fails the job or ii) the default should be
`Integer.MAX_VALUE` and not `0`. Do you know which case applies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
