xuefuz commented on a change in pull request #8449: [FLINK-12235][hive] Support
partition related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8449#discussion_r284840003
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -154,4 +161,13 @@ protected void checkEquals(CatalogView v1, CatalogView
v2) {
// thus properties of Hive view is a super set of those in its
corresponding Flink view
assertTrue(v2.getProperties().entrySet().containsAll(v1.getProperties().entrySet()));
}
+
+ @Override
+ protected void checkEquals(CatalogPartition expected, CatalogPartition
actual) {
+ HiveCatalogPartition hivePartition1 = (HiveCatalogPartition)
expected;
Review comment:
We probably want to make sure the casting is valid before we do so. Better
yet, we need to make sure the classes of the inputs are also equal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
