xuefuz commented on a change in pull request #8449: [FLINK-12235][hive] Support 
partition related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8449#discussion_r286135463
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
 ##########
 @@ -531,11 +520,18 @@ public boolean partitionExists(ObjectPath tablePath, 
CatalogPartitionSpec partit
                return partitions.containsKey(tablePath) && 
partitions.get(tablePath).containsKey(partitionSpec);
        }
 
+       private void ensureFullPartitionSpec(ObjectPath tablePath, 
CatalogPartitionSpec partitionSpec)
 
 Review comment:
   TableNotExistException doesn't seem being thrown anywhere from this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to