yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r285041637
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -187,6 +187,7 @@ public void testRestoreBehaviourWithFaultyStateHandles()
throws Exception {
env.setParallelism(1);
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(Integer.MAX_VALUE,
0));
env.enableCheckpointing(10); // Flink doesn't allow lower than
10 ms
+
env.getCheckpointConfig().setTolerableCheckpointFailureNumber(Integer.MAX_VALUE);
Review comment:
I think the default value should be `0` to keep the same behavior with
`failOnCheckpointingErrors`(default is `true`). I changed it to fix the test
case. Because of some test case (integration test) is not stable, sometimes the
checkpoint would be declined, and they do not accept job recovery by
`CheckpointFailureManager` because they do not allow restart and check the log
files exists the exception message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
