yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r285046388
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -187,6 +187,7 @@ public void testRestoreBehaviourWithFaultyStateHandles()
throws Exception {
env.setParallelism(1);
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(Integer.MAX_VALUE,
0));
env.enableCheckpointing(10); // Flink doesn't allow lower than
10 ms
+
env.getCheckpointConfig().setTolerableCheckpointFailureNumber(Integer.MAX_VALUE);
Review comment:
I understand, my PR changed these test cases' default behavior and caused
them must specify the definite tolerance number (not default). So they may
trigger compatibility problem or cause more test cases failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
