beyond1920 commented on a change in pull request #8462:
[FLINK-12496][table-planner-blink] Support translation from
StreamExecGroupWindowAggregate to StreamTransformation.
URL: https://github.com/apache/flink/pull/8462#discussion_r285412015
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/AggregateUtil.scala
##########
@@ -695,15 +699,43 @@ object AggregateUtil extends Enumeration {
(propPos._1, propPos._2, propPos._3)
}
- def isRowtimeIndicatorType(fieldType: TypeInformation[_]): Boolean = {
- TimeIndicatorTypeInfo.ROWTIME_INDICATOR == fieldType
+ def isRowtimeIndicatorType(fieldType: TypeInformation[_]): Boolean =
fieldType match {
Review comment:
FlinkTypeFactory has already referenced InternalType, RelDataType, and
provide convert conversion functions between these two types. If we move
`isRowtimeIndicatorType`,` isProctimeIndicatorType`, `isTimeIntervalType` and
`isRowIntervalType` to FlinkTypeFactory, then FlinkTypeFactory will reference
three types, which is not good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
