beyond1920 commented on a change in pull request #8462:
[FLINK-12496][table-planner-blink] Support translation from
StreamExecGroupWindowAggregate to StreamTransformation.
URL: https://github.com/apache/flink/pull/8462#discussion_r285840399
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
##########
@@ -309,6 +309,28 @@ public static SimpleDateFormat newDateFormat(String
format) {
return sdf;
}
+ /** Helper for CAST({timestamp} Or {date} or {time} AS VARCHAR(n)). */
+ public static String unixDateTimeToString(Object o, TimeZone tz) {
Review comment:
Do we need to move new added method to `TestSinkUtil `, because almost all
method in `DateTimeUtils` are copied from Calcite... . And new added method
`unixDateTimeToString` is a utility method which is useful, although it's only
used by TestSInkUtil currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
