KurtYoung commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r285499483
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/rank/AbstractTopNFunction.java
##########
@@ -153,12 +155,12 @@ public void open(Configuration parameters) throws
Exception {
// initialize rankEndFetcher
if (!isConstantRankEnd) {
- InternalType rankEndIdxType =
inputRowType.getInternalTypes()[rankEndIndex];
- if (rankEndIdxType.equals(InternalTypes.LONG)) {
+ LogicalType rankEndIdxType =
inputRowType.getLogicalTypes()[rankEndIndex];
+ if (rankEndIdxType instanceof BigIntType) {
Review comment:
check `LogicalTypeRoot` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
