KurtYoung commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r285496817
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryArray.java
##########
@@ -55,20 +62,22 @@ public static int calculateHeaderInBytes(int numFields) {
* It store real value when type is primitive.
* It store the length and offset of variable-length part when type is
string, map, etc.
*/
- public static int calculateFixLengthPartSize(InternalType type) {
- if (type.equals(InternalTypes.BOOLEAN)) {
+ public static int calculateFixLengthPartSize(LogicalType type) {
+ if (type instanceof BooleanType) {
Review comment:
check `LogicalTypeRoot` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
