azagrebin opened a new pull request #8485: [FLINK-12555] Introduce an incapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485 ## What is the purpose of the change At the moment, partition/gate create methods in NetworkEnvironment have a lot of metrics arguments to maintain original layout for metric groups. This approach is not quite incapsulated and clean for shuffle API. We can have just one parent group for shuffle metrics. The old layout can be still maintained in parallel and deprecated. At the moment we can do it with a couple of casts (if shuffle implementation is NetworkEnvironment) and adding an additional legacy metric registration which can be removed later. ## Brief change log - Change `NetworkEnvironment.createResultPartitionWriters/createInputGates` to have only one parent metric group argument. - Add InputChannelMetricsWithLegacy to increment input metrics from the legacy group as well - Move legacy metric group creation to deprecated `NetworkEnvironment.registerLegacyNetworkMetrics` - clean `Task` of legacy code but add call to `NetworkEnvironment.registerLegacyNetworkMetrics` after creation of partitions and gates (later needs instanceOf check for actual ShuffleService) ## Verifying this change simple refactoring, existing tests ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
