twalthr commented on a change in pull request #8508: [FLINK-12533][table]
Introduce TABLE_AGGREGATE_FUNCTION FunctionDefinition.Type
URL: https://github.com/apache/flink/pull/8508#discussion_r286367280
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/AggregateFunctionDefinition.java
##########
@@ -23,10 +23,8 @@
import org.apache.flink.table.functions.UserDefinedAggregateFunction;
import org.apache.flink.util.Preconditions;
-import static
org.apache.flink.table.expressions.FunctionDefinition.Type.AGGREGATE_FUNCTION;
-
/**
- * The function definition of an user-defined aggregate function.
+ * The function definition of an user-defined aggregate or a table aggregate
function.
*/
@PublicEvolving
public final class AggregateFunctionDefinition extends FunctionDefinition {
Review comment:
Can we also introduce a new type of function definition? The type should not
depend on the implementation itself. In the future, the implementation might
not be available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
