[
https://issues.apache.org/jira/browse/FLINK-12497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-12497.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.9.0
master: 0cb56a4dfa9bade080730312ab94b6901c7fb91a
> Refactor the start method of ConnectionManager
> ----------------------------------------------
>
> Key: FLINK-12497
> URL: https://issues.apache.org/jira/browse/FLINK-12497
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In current {{ConnectionManager#start(ResultPartitionProvider,
> TaskEventDispatcher)}}, the parameters in start are only reasonable for
> {{NettyConnectionManager}} implementation, reductant for
> {{LocalConnectionManager}}.
> We could put these parameters in the constructor of
> {{NettyConnectionManager}}, then {{ConnectionManager#start()}} would be more
> cleaner for both implementations. And it could also bring benefits for
> calling start in {{NetworkEnvironment}} which does not need to maintain
> private {{TaskEventDispatcher}} in future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
