dawidwys commented on a change in pull request #8510: [FLINK-12254][table]
Update cast() and TypeLiteralExpression to new type system
URL: https://github.com/apache/flink/pull/8510#discussion_r287676337
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/TypeLiteralExpression.java
##########
@@ -19,28 +19,27 @@
package org.apache.flink.table.expressions;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
-import org.apache.flink.table.utils.TypeStringUtils;
+import org.apache.flink.table.types.DataType;
import org.apache.flink.util.Preconditions;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
/**
- * Expression that wraps {@link TypeInformation} as a literal.
+ * Expression that wraps {@link DataType} as a literal.
Review comment:
nit: How about we add a note why do we need it? That this is primarily used
for casts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
