StefanRRichter commented on a change in pull request #8476:
[FLINK-12490][network] Introduce Input and NetworkInput interfaces
URL: https://github.com/apache/flink/pull/8476#discussion_r287704476
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
##########
@@ -254,7 +248,19 @@ private void handleEndOfPartitionEvent(BufferOrEvent
bufferOrEvent, InputGate in
throw new IllegalStateException("Couldn't find
input gate in set of remaining " +
"input gates.");
}
+ if (isFinished()) {
+ markAvailable();
Review comment:
The naming now is a bit misleading, if I read this as a text: this is
finished and no event will become available anymore, so I mark it as available?
Maybe this shifted the whole concept from indicating availability of data to
indicating that some thing in the status has changed, either data is available
or the input noticed that is it finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
