azagrebin commented on a change in pull request #8320:
[FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r288178257
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -261,8 +260,7 @@ private InputGate createInputGate(
jobId,
gateDescriptor,
new NoOpTaskActions(),
-
InputChannelTestUtils.newUnregisteredInputChannelMetrics(),
Review comment:
We should actually also wrap `gate` here to take wrapping into account in
benchmark tests. Probably with a dummy metric counter, at least forcing the
wrapper to be called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
