azagrebin commented on a change in pull request #8320:
[FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r288960625
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -227,39 +229,22 @@ protected ResultPartitionWriter createResultPartition(
}
private InputGate createInputGate(
- IntermediateDataSetID dataSetID,
- ExecutionAttemptID executionAttemptID,
final TaskManagerLocation senderLocation,
- NetworkEnvironment environment,
+ final SingleInputGateFactory gateFactory,
Review comment:
is `gateFactory` not already available as a class field in the method?
strange that the field is protected, can be private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
