azagrebin commented on a change in pull request #8529: [FLINK-12603][network]
Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#discussion_r288223427
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -53,12 +54,13 @@ public static CheckpointBarrierHandler
createCheckpointBarrierHandler(
+ " must be positive or -1 (infinite)");
}
+ int pageSize =
NetworkEnvironmentConfiguration.getPageSize(taskManagerConfig);
Review comment:
Are we going to have page size and `NETWORK_CREDIT_MODEL` for all shuffle
services? Or is there any other better way how to abstract BarrierBuffer
creation, like asking NetworkEnvironment/ShuffleService about needed parameters
and pass them into Environment/StreamTasks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
