azagrebin commented on a change in pull request #8529: [FLINK-12603][network]
Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#discussion_r288210019
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -140,12 +140,13 @@ public StreamTwoInputProcessor(
TwoInputStreamOperator<IN1, IN2, ?> streamOperator,
TaskIOMetricGroup metrics,
WatermarkGauge input1WatermarkGauge,
- WatermarkGauge input2WatermarkGauge) throws IOException
{
+ WatermarkGauge input2WatermarkGauge,
+ String taskName) throws IOException {
final InputGate inputGate =
InputGateUtil.createInputGate(inputGates1, inputGates2);
this.barrierHandler =
InputProcessorUtil.createCheckpointBarrierHandler(
- checkpointedTask, checkpointMode, ioManager, inputGate,
taskManagerConfig);
+ checkpointedTask, checkpointMode, ioManager, inputGate,
taskManagerConfig, taskName);
Review comment:
codestyle: let's break all function argument into separate lines if the line
is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
