1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke
timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288242715
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -794,23 +796,24 @@ public void testOperatorClosingBeforeStopRunning()
throws Throwable {
}
}
- /**
- * Test set user code ClassLoader before calling ProcessingTimeCallback.
- */
@Test
- public void testSetsUserCodeClassLoaderForTimerThreadFactory() throws
Throwable {
- syncLatch = new OneShotLatch();
-
+ public void testThreadInvariants() throws Throwable {
Review comment:
I haven't talked with the author of the old test. But:
1. the old test doesn't work anymore, as it deadlocks. This is expected,
due to the change in this PR.
2. the thing that was checked by the test, doesn't required anymore, as the
timer thread is not execution user code anymore.
Above two reasons why the test could have been removed. But instead, I have
modified it to tailor to the new situation with mailbox (I don't know if such
check already exists).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
