1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke
timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288258556
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1358,4 +1358,19 @@ public void actionsUnavailable() throws
InterruptedException {
mailbox.putMail(actionUnavailableLetter);
}
}
+
+ private class TimerInvocationContext implements
SystemProcessingTimeService.ScheduledCallbackExecutionContext {
+ @Override
+ public void invoke(ProcessingTimeCallback callback, long
timestamp) throws InterruptedException {
+ mailbox.putMail(() -> {
+ synchronized (getCheckpointLock()) {
Review comment:
It is possible that there is some misunderstanding.
IRC, the discussion started in context of this PR only (not involving any
future changes in other tickets). In particular, if the lock here is still
needed (taking into account that there is a new lock in `SourceStreamTask`
added in #8442).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
