azagrebin commented on a change in pull request #8496: [FLINK-12571][network]
Make NetworkEnvironment#start() return the binded data port
URL: https://github.com/apache/flink/pull/8496#discussion_r288454716
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ConnectionManager.java
##########
@@ -26,6 +26,11 @@
*/
public interface ConnectionManager {
+ /**
+ * Starts the internal related components for network connection and
communication.
+ *
+ * @return the data port of server bind address if have.
+ */
Review comment:
I would write it like this:
```
/**
* Starts the internal related components for network connection and
communication.
*
* @return a port to connect to the task executor for shuffle data
exchange, -1 if only local connection is possible.
*/
```
I think the same comment is relevant for `NetworkEnvironment`.
We could already squash this fixup into the previous commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
